Remove newline from download sbom output
#1732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmt.Fprintln inserts a newline that isn't in the original payload. This frustrates the process of comparing the sha256sum of the output to the original. Signed-off-by: Rob Best <robertbest89@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #1732 +/- ##
==========================================
+ Coverage 29.25% 29.52% +0.27%
==========================================
Files 141 141
Lines 8502 8502
==========================================
+ Hits 2487 2510 +23
+ Misses 5742 5718 -24
- Partials 273 274 +1
Continue to review full report at Codecov.
|
dlorenc
approved these changes
Apr 10, 2022
|
Nice!!! |
mlieberman85
pushed a commit
to mlieberman85/cosign
that referenced
this pull request
May 6, 2022
fmt.Fprintln inserts a newline that isn't in the original payload. This frustrates the process of comparing the sha256sum of the output to the original. Signed-off-by: Rob Best <robertbest89@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I had reason to compare the downloaded SBOM to the original payload I uploaded and noticed that the sha256 sum is different because it prints out an extra newline that isn't in the initial payload:
This PR removes the new line so what you get is exactly what was uploaded.
Release Note