GHSA-66x3-6cw3-v5gj: Update go-tuf to v0.3.0 #1894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janisz
force-pushed
the
main
branch
2 times, most recently
from
1382f32
to
4dc866f
Compare
|
Cc @asraa and @haydentherapper |
|
I think this should be handled by @dependabot |
Signed-off-by: Tomasz Janiszewski <janiszt@gmail.com>
asraa
approved these changes
May 18, 2022
| @@ -425,7 +425,7 @@ func embeddedLocalStore() (client.LocalStore, error) { | |||
| func (t *TUF) updateMetadataAndDownloadTargets() error { | |||
| // Download updated targets and cache new metadata and targets in ${TUF_ROOT}. | |||
| targetFiles, err := t.client.Update() | |||
| if err != nil && !client.IsLatestSnapshot(err) { | |||
| if err != nil { | |||
There was a problem hiding this comment.
Why was this removed?
There was a problem hiding this comment.
It's obsolete -- TUF used to error out if the update fetched a snapshot with the same version, and that was removed.
See change in https://github.com/theupdateframework/go-tuf/pull/143/files when go-tuf updated to follow the spec for client updates
There was a problem hiding this comment.
SG
Looks like some e2e tests failed
This was referenced May 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update go-tuf
There is one security update GHSA-66x3-6cw3-v5gj!
https://github.com/theupdateframework/go-tuf/releases/tag/v0.3.0