Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --oidc-provider flag to specify which provider to use for ambient credentials #1998

Merged
merged 1 commit into from
Jun 15, 2022

Conversation

priyawadhwa
Copy link
Contributor

@priyawadhwa priyawadhwa commented Jun 15, 2022

This should help fix #1993

This way we can use the flag to specify one provider (e.g. spiffe) while still having credentials for another mounted in (e.g. google)

Add --oidc-provider flag to specify which provider to use for ambient credentials

cc @strongjz

@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2022

Codecov Report

Merging #1998 (e1c56fd) into main (b01a173) will decrease coverage by 2.52%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1998      +/-   ##
==========================================
- Coverage   28.69%   26.16%   -2.53%     
==========================================
  Files         133      127       -6     
  Lines        8092     7422     -670     
==========================================
- Hits         2322     1942     -380     
+ Misses       5463     5225     -238     
+ Partials      307      255      -52     
Impacted Files Coverage Δ
cmd/cosign/cli/attest.go 0.00% <0.00%> (ø)
cmd/cosign/cli/fulcio/fulcio.go 18.10% <0.00%> (-1.53%) ⬇️
cmd/cosign/cli/options/oidc.go 0.00% <0.00%> (ø)
cmd/cosign/cli/policy_init.go 1.39% <0.00%> (-0.01%) ⬇️
cmd/cosign/cli/sign.go 0.00% <0.00%> (ø)
pkg/cosign/tuf/status_type.go
pkg/cosign/tuf/signer.go
pkg/cosign/tuf/client.go
pkg/cosign/tuf/policy.go
pkg/cosign/tuf/usage_type.go
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b01a173...e1c56fd. Read the comment docs.

@dlorenc
Copy link
Member

dlorenc commented Jun 15, 2022

Missing DCO, otherwise LGTM!

… credentials

Signed-off-by: Priya Wadhwa <priya@chainguard.dev>
@priyawadhwa
Copy link
Contributor Author

Whoops, fixed!

@priyawadhwa priyawadhwa merged commit 655a681 into sigstore:main Jun 15, 2022
@priyawadhwa priyawadhwa deleted the add-provider-flag branch June 15, 2022 14:04
@github-actions github-actions bot added this to the v1.10.0 milestone Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cosign, Spire, and Attestation failures
3 participants