Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message when no sigs/atts are found for an image #2101

Merged
merged 1 commit into from
Jul 26, 2022

Conversation

imjasonh
Copy link
Member

Signed-off-by: Jason Hall jason@chainguard.dev

Before this change, if you cosign download attestation $image and none were found:

Error: no attestations associated with ghcr.io/distroless/static: %!w(<nil>)

After this change:

Error: no attestations associated with ghcr.io/distroless/static

At this point in the code, the err is known to be nil -- if there was an error, you'd get the message fetching attestations: whatever error happened.

Release Note

NONE

Documentation

N/A

Signed-off-by: Jason Hall <jason@chainguard.dev>
@dlorenc dlorenc merged commit 8066a9e into sigstore:main Jul 26, 2022
@github-actions github-actions bot added this to the v1.11.0 milestone Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants