Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove style jobs and cleanup makefile gofmt and goimports are running already with golangci-lint #2105

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Jul 27, 2022

Summary

  • remove style jobs and cleanup makefile gofmt and goimports are running already with golangci-lint
  • update golangci-lint

also:
Fixes: #2084

Release Note

n/a

Documentation

n/a

@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2022

Codecov Report

Merging #2105 (1850dec) into main (3a6088d) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2105      +/-   ##
==========================================
- Coverage   26.33%   26.27%   -0.07%     
==========================================
  Files         129      129              
  Lines        7564     7574      +10     
==========================================
- Hits         1992     1990       -2     
- Misses       5317     5329      +12     
  Partials      255      255              
Impacted Files Coverage Δ
pkg/policy/eval.go 78.94% <0.00%> (-0.54%) ⬇️
pkg/cosign/rego/rego.go 70.96% <0.00%> (-0.47%) ⬇️
cmd/cosign/cli/sign/sign.go 14.57% <0.00%> (-0.13%) ⬇️
pkg/cosign/fetch.go 0.00% <0.00%> (ø)
cmd/cosign/cli/sign.go 0.00% <0.00%> (ø)
cmd/cosign/cli/options/sign.go 0.00% <0.00%> (ø)
cmd/cosign/cli/options/attest.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

@cpanato
Copy link
Member Author

cpanato commented Jul 27, 2022

running locally i dont see this error

$ /Users/cpanato/code/src/github.com/sigstore/cosign/bin/golangci-lint version
golangci-lint has version v1.47.2 built from (unknown, mod sum: "h1:qvMDVv49Hrx3PSEXZ0bD/yhwSbhsOihQjFYCKieegIw=") on (unknown)

$ /Users/cpanato/code/src/github.com/sigstore/cosign/bin/golangci-lint run --out-format=github-actions --timeout=5m
WARN [linters context] structcheck is disabled because of go1.18. You can track the evolution of the go1.18 support by following the https://github.com/golangci/golangci-lint/issues/2649.
WARN [linters context] tparallel is disabled because of go1.18. You can track the evolution of the go1.18 support by following the https://github.com/golangci/golangci-lint/issues/2649.

…g already with golangci-lint

Signed-off-by: cpanato <ctadeu@gmail.com>
@dlorenc dlorenc merged commit 5b57154 into sigstore:main Jul 27, 2022
@github-actions github-actions bot added this to the v1.11.0 milestone Jul 27, 2022
@cpanato cpanato deleted the cleanup branch July 27, 2022 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cosign 1.9.0 make all complains about goimports
4 participants