Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove experimental mode from cosign attest and verify-attestation #2458

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

priyawadhwa
Copy link
Contributor

Signed-off-by: Priya Wadhwa priya@chainguard.dev

Ref #2255

Release Note

Remove experimental mode from cosign attest and verify-attestation

Signed-off-by: Priya Wadhwa <priya@chainguard.dev>
@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2022

Codecov Report

Merging #2458 (2fd3b4c) into main (da32b91) will increase coverage by 0.33%.
The diff coverage is 50.51%.

@@            Coverage Diff             @@
##             main    #2458      +/-   ##
==========================================
+ Coverage   30.65%   30.98%   +0.33%     
==========================================
  Files         138      138              
  Lines        8404     8469      +65     
==========================================
+ Hits         2576     2624      +48     
- Misses       5494     5505      +11     
- Partials      334      340       +6     
Impacted Files Coverage Δ
cmd/cosign/cli/attest.go 0.00% <0.00%> (ø)
cmd/cosign/cli/options/signblob.go 0.00% <0.00%> (ø)
cmd/cosign/cli/options/verify.go 0.00% <0.00%> (ø)
cmd/cosign/cli/sign/sign.go 15.71% <0.00%> (-0.13%) ⬇️
cmd/cosign/cli/sign/sign_blob.go 0.00% <0.00%> (ø)
cmd/cosign/cli/signblob.go 0.00% <0.00%> (ø)
cmd/cosign/cli/verify.go 0.00% <0.00%> (ø)
cmd/cosign/cli/verify/verify_attestation.go 0.00% <0.00%> (ø)
pkg/cosign/keys.go 61.36% <ø> (ø)
cmd/cosign/cli/verify/verify.go 19.16% <20.00%> (+0.63%) ⬆️
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@priyawadhwa priyawadhwa requested review from hectorj2f and haydentherapper and removed request for haydentherapper November 15, 2022 02:35
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@priyawadhwa priyawadhwa merged commit 709a2c0 into sigstore:main Nov 15, 2022
@github-actions github-actions bot added this to the v1.14.0 milestone Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants