2476 predicate type download #2484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaospuppy
force-pushed
the
2476-predicate-type-download
branch
2 times, most recently
from
9a1f267
to
75b780b
Compare
hectorj2f
reviewed
Nov 28, 2022
hectorj2f
reviewed
Nov 28, 2022
hectorj2f
reviewed
Nov 28, 2022
hectorj2f
reviewed
Nov 28, 2022
|
Resolved all threads @hectorj2f |
hectorj2f
reviewed
Nov 28, 2022
hectorj2f
reviewed
Nov 28, 2022
|
Looks like I have a few more places to set arguments to FetchAttestationsForReference as well. |
Codecov Report
@@ Coverage Diff @@
## main #2484 +/- ##
==========================================
- Coverage 30.03% 29.95% -0.09%
==========================================
Files 139 139
Lines 8586 8609 +23
==========================================
Hits 2579 2579
- Misses 5649 5672 +23
Partials 358 358
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
chaospuppy
force-pushed
the
2476-predicate-type-download
branch
from
0d76a22
to
835a336
Compare
|
E2E tests have been updated, as has the help text for |
|
@hectorj2f any outstanding issues on this PR that you see? |
|
Hi again @hectorj2f, just pinging on this again to see if it could be merged in. |
hectorj2f
reviewed
Jan 10, 2023
| // AddFlags implements Interface | ||
| func (o *AttestationDownloadOptions) AddFlags(cmd *cobra.Command) { | ||
| cmd.Flags().StringVar(&o.PredicateType, "predicate-type", "", | ||
| "download attestation with matching predicateType annotation") |
There was a problem hiding this comment.
Future suggestion: this could be an array of matching annotations.
|
I added more reviewers to avoid missing anything here. It looks good to me. |
znewman01
previously approved these changes
Feb 6, 2023
|
BTW you may have to rebase to get tests to run, sorry! I'll re-approve quick this time. |
Signed-off-by: Tim Seagren <seagren.tim@solute.us>
Signed-off-by: Tim Seagren <seagren.tim@solute.us>
Signed-off-by: Tim Seagren <seagren.tim@solute.us>
Signed-off-by: Tim Seagren <seagren.tim@solute.us>
Signed-off-by: Tim Seagren <seagren.tim@solute.us>
…e-type option for attestation download Signed-off-by: Tim Seagren <seagren.tim@solute.us>
Signed-off-by: Tim Seagren <seagren.tim@solute.us>
Signed-off-by: Tim Seagren <seagren.tim@solute.us>
Signed-off-by: Tim Seagren <seagren.tim@solute.us>
Signed-off-by: Tim Seagren <seagren.tim@solute.us>
…p text for --predicate-type Signed-off-by: Tim Seagren <seagren.tim@solute.us>
Signed-off-by: Tim Seagren <seagren.tim@solute.us>
chaospuppy
force-pushed
the
2476-predicate-type-download
branch
from
835a336
to
15d8562
Compare
|
@znewman01 no worries, rebased. |
znewman01
approved these changes
Feb 8, 2023
dmitris
pushed a commit
to dmitris/cosign
that referenced
this pull request
Mar 24, 2023
* add cyclonedxxml predicatetype Signed-off-by: Tim Seagren <seagren.tim@solute.us> * read cyclonedx xml bytes into cyclonedx.SBOM Signed-off-by: Tim Seagren <seagren.tim@solute.us> * add e2e test Signed-off-by: Tim Seagren <seagren.tim@solute.us> * update cli docs Signed-off-by: Tim Seagren <seagren.tim@solute.us> * add artibrary annotations to mainfest Signed-off-by: Tim Seagren <seagren.tim@solute.us> * add predicateType annotation to attestation manifests, add --predicate-type option for attestation download Signed-off-by: Tim Seagren <seagren.tim@solute.us> * remove unrelated changes Signed-off-by: Tim Seagren <seagren.tim@solute.us> * update PredicateType as field of c Signed-off-by: Tim Seagren <seagren.tim@solute.us> * apply suggestions Signed-off-by: Tim Seagren <seagren.tim@solute.us> * remove unused index var Signed-off-by: Tim Seagren <seagren.tim@solute.us> * add e2e tests for attestation download, resolve data race, update help text for --predicate-type Signed-off-by: Tim Seagren <seagren.tim@solute.us> * CreateAttestationReplace Signed-off-by: Tim Seagren <seagren.tim@solute.us> --------- Signed-off-by: Tim Seagren <seagren.tim@solute.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #2476
Summary
This PR will add a
predicateTypeannotation to the manifest of each attestation. This annotation can then be used with thecosign download attestationcommand to output only the desired annotation, using a new—predicate-typeflag. If the flag is used, but nopredicateTypeannotation is matched, an error is raised. If the flag is not provided, all attestations are returned, as they are currently.Release Note
New Feature: filter attestations output from
cosign download attestationcommand by using the—predicate-typeflag.Documentation
This will require an update to the README for the
cosign downloadcommand, which will be updated provided this seems like a good idea.