Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change go module name to github.com/sigstore/cosign/v2 for Cosign 2.0 #2544

Merged
merged 2 commits into from
Dec 14, 2022

Conversation

priyawadhwa
Copy link
Contributor

Signed-off-by: Priya Wadhwa priya@chainguard.dev

This is required to build a 2.0 version by go modules, the original rc release failed with this error:

/workspace/go/src/sigstore/cosign/dist/proxy/linux/go.mod:4: require github.com/sigstore/cosign: version "v2.0.0-rc.0" invalid: should be v0 or v1, not v2

Release Note

Change go module name to github.com/sigstore/cosgn/v2 for Cosign 2.0

Signed-off-by: Priya Wadhwa <priya@chainguard.dev>
@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2022

Codecov Report

Merging #2544 (b95365c) into main (d2c842d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2544   +/-   ##
=======================================
  Coverage   30.08%   30.08%           
=======================================
  Files         139      139           
  Lines        8607     8607           
=======================================
  Hits         2589     2589           
  Misses       5642     5642           
  Partials      376      376           
Impacted Files Coverage Δ
cmd/cosign/cli/attach.go 0.00% <ø> (ø)
cmd/cosign/cli/attest.go 0.00% <ø> (ø)
cmd/cosign/cli/attest_blob.go 0.00% <ø> (ø)
cmd/cosign/cli/clean.go 0.00% <ø> (ø)
cmd/cosign/cli/commands.go 0.00% <ø> (ø)
cmd/cosign/cli/copy.go 0.00% <ø> (ø)
cmd/cosign/cli/dockerfile.go 0.00% <ø> (ø)
cmd/cosign/cli/dockerfile/verify.go 41.66% <ø> (ø)
cmd/cosign/cli/download.go 0.00% <ø> (ø)
cmd/cosign/cli/env.go 76.82% <ø> (ø)
... and 78 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Priya Wadhwa <priya@chainguard.dev>
@cpanato cpanato changed the title Change go module name to github.com/sigstore/cosgn/v2 for Cosign 2.0 Change go module name to github.com/sigstore/cosign/v2 for Cosign 2.0 Dec 14, 2022
@@ -1,4 +1,4 @@
module github.com/sigstore/cosign
module github.com/sigstore/cosign/v2

go 1.18
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we bump this to 1.19? 1.20 is almost out and 1.18 will be deprecated

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's smart but let's do it in a different PR

Copy link
Contributor

@znewman01 znewman01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gosh I love how "simple" Go is, good work Golang team

@znewman01 znewman01 merged commit 27bb6ad into sigstore:main Dec 14, 2022
@github-actions github-actions bot added this to the v1.14.0 milestone Dec 14, 2022
@priyawadhwa priyawadhwa deleted the gomod-2.0 branch December 14, 2022 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants