Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix github oidc post submit test #2594

Merged
merged 2 commits into from
Jan 4, 2023
Merged

Conversation

asraa
Copy link
Contributor

@asraa asraa commented Jan 4, 2023

Signed-off-by: Asra Ali asraa@google.com

Post submits are failing: https://github.com/sigstore/cosign/actions/runs/3841395491/jobs/6541562978

I think because they need to skip confirmation for the TLOG upload.

+ echo 'Sign the blob with cosign first and upload to rekor'
+ ./cosign sign-blob --output-certificate blob.cert --output-signature blob.sig verify-experimental-blob
Wed Jan  4 20:45:00 UTC 20[23](https://github.com/sigstore/cosign/actions/runs/3841395491/jobs/6541562978#step:7:24)
Sign the blob with cosign first and upload to rekor
Using payload from: verify-experimental-blob
Generating ephemeral keys...
Retrieving signed certificate...
Successfully verified SCT...
By typing 'y', you attest that you grant (or have permission to grant) and agree to have this information stored permanently in transparency logs.
Are you sure you would like to continue? [y/N] Error: signing verify-experimental-blob: upload to tlog: user declined the prompt
main.go:62: error during command execution: signing verify-experimental-blob: upload to tlog: user declined the prompt
make: *** [test/ci.mk:16: sign-blob-experimental] Error 1

Summary

Release Note

Documentation

Signed-off-by: Asra Ali <asraa@google.com>
@asraa asraa requested a review from priyawadhwa January 4, 2023 20:48
@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2023

Codecov Report

Merging #2594 (61fc0a0) into main (0081e1a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2594   +/-   ##
=======================================
  Coverage   30.09%   30.09%           
=======================================
  Files         146      146           
  Lines        9113     9113           
=======================================
  Hits         2743     2743           
  Misses       5961     5961           
  Partials      409      409           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

cpanato
cpanato previously approved these changes Jan 4, 2023
@@ -30,7 +30,7 @@ date > $BLOB
cat $BLOB

echo "Sign the blob with cosign first and upload to rekor"
$COSIGN_CLI sign-blob --output-certificate blob.cert --output-signature blob.sig $BLOB
$COSIGN_CLI sign-blob -y --output-certificate blob.cert --output-signature blob.sig $BLOB
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not: Can we make that explicity with the full flag name?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes! done

Signed-off-by: Asra Ali <asraa@google.com>
@asraa asraa enabled auto-merge (squash) January 4, 2023 23:34
@asraa asraa merged commit 6fc34f2 into sigstore:main Jan 4, 2023
@github-actions github-actions bot added this to the v1.14.0 milestone Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants