feat: implements exit code functionality #2673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #2673 +/- ##
========================================
Coverage 30.00% 30.01%
========================================
Files 146 150 +4
Lines 9299 9406 +107
========================================
+ Hits 2790 2823 +33
- Misses 6077 6151 +74
Partials 432 432
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Itxaka
reviewed
Jan 28, 2023
cmd/cosign/errors/generate_docs.go
Outdated
| // convieniently solved this problem prior: https://github.com/rancher/elemental-cli/blob/main/docs/generate_docs.go | ||
| // there was no need to change (apart from some file paths) due to it | ||
| // giving us exactly what we want without error. | ||
| func GenerateExitCodeDocs() error { |
There was a problem hiding this comment.
Damn, beautiful code. Only a genius could write something as beautiful as this ;)
There was a problem hiding this comment.
Standing on the shoulders of giants as they say 😝
|
Looking really nice! |
znewman01
previously approved these changes
Feb 6, 2023
- adds exit code functionality that allows for cosign to return sensible exit codes for specific errors. the exit code document generation is automatically baked into the `docgen` step. - adds first exit code for no matching signatures and added two more ready for addition in future PR. - is backwards compatible and will throw exit code 1 for all non defined error types/exit code permutations. Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
ChrisJBurns
force-pushed
the
adds-exit-code-func
branch
from
4bbed84
to
285f24a
Compare
|
@znewman01 All good to go, permitting the Workflow Gods are happy 😄 |
|
Ugh, I kicked off the workflows 3 days ago and the Windows one is hung. Re-running... |
znewman01
approved these changes
Feb 10, 2023
dmitris
pushed a commit
to dmitris/cosign
that referenced
this pull request
Mar 24, 2023
- adds exit code functionality that allows for cosign to return sensible exit codes for specific errors. the exit code document generation is automatically baked into the `docgen` step. - adds first exit code for no matching signatures and added two more ready for addition in future PR. - is backwards compatible and will throw exit code 1 for all non defined error types/exit code permutations. Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
docgenstep.make lintas it was 4 versions behind the one used in Actions workflow.Addresses some of #948 (further PR's to address completely)
Signed-off-by: ChrisJBurns 29541485+ChrisJBurns@users.noreply.github.com