Add Buildkite provider #2779
Merged
Add Buildkite provider #2779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inspired by https://github.com/buildkite/agent/blob/main/clicommand/oidc_request_token.go, this should replicate the logic used when calling 'buildkite-agent oidc request-token' Fixes sigstore#2778 Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
haydentherapper
force-pushed
the
buildkite-provider
branch
from
717fcd3
to
88db6a7
Compare
mattmoor
previously approved these changes
Mar 8, 2023
pkg/providers/buildkite/buildkite.go
Outdated
Comment on lines
51
to
52
| l := logger.NewConsoleLogger(logger.NewTextPrinter(os.Stderr), os.Exit) | ||
| l.SetLevel(logger.INFO) |
There was a problem hiding this comment.
Does this log anything? Perhaps have this package put the default log level in a global variable, so folks can change it if this is noisy?
There was a problem hiding this comment.
Good idea! There was an existing environment variable, I've plumbed that through to the logger.
Codecov Report
@@ Coverage Diff @@
## main #2779 +/- ##
=======================================
Coverage 29.54% 29.54%
=======================================
Files 151 151
Lines 9646 9646
=======================================
Hits 2850 2850
Misses 6357 6357
Partials 439 439
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
I built a binary w/ this branch (specifically commit 88db6a7) and successfully tested it in a buildkite pipeline with |
Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
cpanato
approved these changes
Mar 9, 2023
mattmoor
approved these changes
Mar 9, 2023
done |
dmitris
pushed a commit
to dmitris/cosign
that referenced
this pull request
Mar 24, 2023
* Add Buildkite provider Inspired by https://github.com/buildkite/agent/blob/main/clicommand/oidc_request_token.go, this should replicate the logic used when calling 'buildkite-agent oidc request-token' Fixes sigstore#2778 Signed-off-by: Hayden Blauzvern <hblauzvern@google.com> * Support customizing log level based on env var Signed-off-by: Hayden Blauzvern <hblauzvern@google.com> --------- Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by
https://github.com/buildkite/agent/blob/main/clicommand/oidc_request_token.go, this should replicate the logic used when calling
'buildkite-agent oidc request-token'
Fixes #2778
Summary
Release Note
Added provider for Buildkite CI. Identity tokens will be automatically fetched when signing on Buildkite.
Documentation