Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tag warning message from save/copy commands #2799

Merged
merged 1 commit into from
Mar 15, 2023

Conversation

znewman01
Copy link
Contributor

Partially undoes #2650 (CC @priyawadhwa)

We need to warn when the user might be making a statement about the wrong image, but not for downloading.

Release Note

NONE

Documentation

N/A

Signed-off-by: Zachary Newman <zjn@chainguard.dev>
@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Merging #2799 (c0aa38e) into main (7d4e5c1) will increase coverage by 0.54%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2799      +/-   ##
==========================================
+ Coverage   28.98%   29.52%   +0.54%     
==========================================
  Files         151      151              
  Lines        9657     9653       -4     
==========================================
+ Hits         2799     2850      +51     
+ Misses       6438     6364      -74     
- Partials      420      439      +19     
Impacted Files Coverage Δ
cmd/cosign/cli/save.go 0.00% <ø> (ø)

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@hectorj2f hectorj2f merged commit 580f819 into sigstore:main Mar 15, 2023
@github-actions github-actions bot added this to the v1.14.0 milestone Mar 15, 2023
dmitris pushed a commit to dmitris/cosign that referenced this pull request Mar 24, 2023
Signed-off-by: Zachary Newman <zjn@chainguard.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants