-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: split OIDC providers into separate Go modules #3059
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3059 +/- ##
===========================================
+ Coverage 30.64% 48.91% +18.27%
===========================================
Files 155 68 -87
Lines 9791 4657 -5134
===========================================
- Hits 3000 2278 -722
+ Misses 6341 2077 -4264
+ Partials 450 302 -148
|
Signed-off-by: Jason Hall <jason@chainguard.dev>
Signed-off-by: Jason Hall <jason@chainguard.dev>
Signed-off-by: Jason Hall <jason@chainguard.dev>
Signed-off-by: Jason Hall <jason@chainguard.dev>
Signed-off-by: Jason Hall <jason@chainguard.dev>
Signed-off-by: Jason Hall <jason@chainguard.dev>
Signed-off-by: Jason Hall <jason@chainguard.dev>
Signed-off-by: Jason Hall <jason@chainguard.dev>
Signed-off-by: Jason Hall <jason@chainguard.dev>
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
This PR was closed because it has been stalled for 10 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR demonstrates splitting the current single Go module into a number of smaller Go modules:
./pkg/providers/{buildkite,google,spiffe}
implements a provider for various OIDC creds, which rely on sometimes-heavy helper libraries./pkg/providers/all
is a convenience to import the above modules; it's deprecated in this PR./cmd/cosign
is the CLI, which depends on the OIDC providers./
is the root module, which is "cosign as a library", now without many heavy dependencies./test
depends on./cmd/cosign
and provides e2e tests./cmd/help
depends on./cmd/cosign
[WIP]Because some functionality and tests in the root module need them:
./test/
to./pkg/cosign/test
./cmd/cosign/cli/options
to./pkg/cosign/policy
Previously, inspired by sigstore/sigstore#1115
TODO
make test
to test each module, sincego test ./...
won't anymore