Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI issues for forked repos #537

Merged
merged 2 commits into from
Aug 12, 2021
Merged

Fix CI issues for forked repos #537

merged 2 commits into from
Aug 12, 2021

Conversation

imjasonh
Copy link
Member

@imjasonh imjasonh commented Aug 12, 2021

This fixes two CI-related issues hit while proposing #536

  1. e2e tests are run for all pushes, even to forked repos. This causes them to fail when they don't have the required secret configured. See https://github.com/imjasonh/cosign/actions/runs/1125396335 -- this change disables e2e tests when the repo != sigstore/cosign, and tells GitHub Actions to run the workflow when it's as a PR to the cosign repo, not only when it's a push. Also allow manual execution, because why not.
  2. CI tests failed due to an out-of-date module dependency. See https://github.com/imjasonh/cosign/actions/runs/1125396339 -- this change runs the go get command in that error message.

This change also removes some unnecessary comments from e2e_tests.yml for (I think) better readability.

Signed-off-by: Jason Hall <jasonhall@redhat.com>
Signed-off-by: Jason Hall <jasonhall@redhat.com>
@dlorenc dlorenc merged commit 3b5c238 into sigstore:main Aug 12, 2021
@cpanato cpanato added this to the v1.1.0 milestone Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants