update Go to 1.17.0 #568
Merged
update Go to 1.17.0 #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jake Sanders <jsand@google.com>
|
I think you missed one spot here: https://github.com/sigstore/cosign/blob/main/release/cloudbuild.yaml |
They've always lagged a bit behind upstream Go releases: ghcr.io/gythialy/golang-cross |
dlorenc
approved these changes
Aug 24, 2021
znewman01
added a commit
to znewman01/cosign
that referenced
this pull request
Jan 19, 2022
[sigstore#568](sigstore#568) bumps the Go version for tests to 1.17. Now they break for 1.16: ```sh TMPDIR=$(mktemp -d) cd $TMPDIR git clone https://github.com/sigstore/cosign 2> /dev/null cd cosign for go in go_1_16 go_1_17; do nix-shell \ -p ${go} \ -p gnumake \ --command 'make test' \ > /dev/null 2>&1 if [ $? -eq 0 ]; then echo ${go} good else echo ${go} bad fi done ``` [sigstore#1252](sigstore#1252) adds a call to `testing.T.Setenv`, added in [1.17](https://go-review.googlesource.com/c/go/+/326790/3/api/go1.17.txt), which caused this breakage. (We're still testing *builds* on 1.16, so that's fine.)
znewman01
added a commit
to znewman01/cosign
that referenced
this pull request
Jan 19, 2022
[sigstore#568](sigstore#568) bumps the Go version for tests to 1.17. Now they break for 1.16: ```sh TMPDIR=$(mktemp -d) cd $TMPDIR git clone https://github.com/sigstore/cosign 2> /dev/null cd cosign for go in go_1_16 go_1_17; do nix-shell \ -p ${go} \ -p gnumake \ --command 'make test' \ > /dev/null 2>&1 if [ $? -eq 0 ]; then echo ${go} good else echo ${go} bad fi done ``` [sigstore#1252](sigstore#1252) adds a call to `testing.T.Setenv`, added in [1.17](https://go-review.googlesource.com/c/go/+/326790/3/api/go1.17.txt), which caused this breakage. (We're still testing *builds* on 1.16, so that's fine.) Signed-off-by: Zachary Newman <z@znewman.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jake Sanders jsand@google.com