Refactor the tuf client code. #1252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlorenc
force-pushed
the
wiptuf
branch
3 times, most recently
from
6868353
to
41e66f7
Compare
|
Test failure looks like it's because the distroless image builds failed: This works: $ COSIGN_EXPERIMENTAL=1 ./cosign verify gcr.io/distroless/base:0a3c30a19ffb51f79c34955fdb9b77b8aa3b4309This one doesn't: $ COSIGN_EXPERIMENTAL=1 ./cosign verify gcr.io/distroless/base:latestWe should probably just pin to a known good signed image here. |
dlorenc
force-pushed
the
wiptuf
branch
2 times, most recently
from
45b7ebe
to
192c31e
Compare
dlorenc
changed the title
dlorenc
force-pushed
the
wiptuf
branch
4 times, most recently
from
2fadb56
to
6f9ed4c
Compare
dlorenc
force-pushed
the
wiptuf
branch
11 times, most recently
from
3abe1ba
to
187a7c0
Compare
This is my attempt at refactoring the TUF client code to better support the configuration modes we've recently added. This also adds support for SIGSTORE_NO_CACHE, and eliminates most writes to disk from cosign outside of cosign initialize. I think these tests are about equivalent to what we had before, if not a bit better. The coverage is at 72% and hits most non-sporadic errors. Signed-off-by: Dan Lorenc <lorenc.d@gmail.com>
hectorj2f
approved these changes
Dec 28, 2021
znewman01
added a commit
to znewman01/cosign
that referenced
this pull request
Jan 19, 2022
[sigstore#568](sigstore#568) bumps the Go version for tests to 1.17. Now they break for 1.16: ```sh TMPDIR=$(mktemp -d) cd $TMPDIR git clone https://github.com/sigstore/cosign 2> /dev/null cd cosign for go in go_1_16 go_1_17; do nix-shell \ -p ${go} \ -p gnumake \ --command 'make test' \ > /dev/null 2>&1 if [ $? -eq 0 ]; then echo ${go} good else echo ${go} bad fi done ``` [sigstore#1252](sigstore#1252) adds a call to `testing.T.Setenv`, added in [1.17](https://go-review.googlesource.com/c/go/+/326790/3/api/go1.17.txt), which caused this breakage. (We're still testing *builds* on 1.16, so that's fine.)
znewman01
added a commit
to znewman01/cosign
that referenced
this pull request
Jan 19, 2022
[sigstore#568](sigstore#568) bumps the Go version for tests to 1.17. Now they break for 1.16: ```sh TMPDIR=$(mktemp -d) cd $TMPDIR git clone https://github.com/sigstore/cosign 2> /dev/null cd cosign for go in go_1_16 go_1_17; do nix-shell \ -p ${go} \ -p gnumake \ --command 'make test' \ > /dev/null 2>&1 if [ $? -eq 0 ]; then echo ${go} good else echo ${go} bad fi done ``` [sigstore#1252](sigstore#1252) adds a call to `testing.T.Setenv`, added in [1.17](https://go-review.googlesource.com/c/go/+/326790/3/api/go1.17.txt), which caused this breakage. (We're still testing *builds* on 1.16, so that's fine.) Signed-off-by: Zachary Newman <z@znewman.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the tuf client code.
This is my attempt at refactoring the TUF client code to better
support the configuration modes we've recently added.
This also adds support for SIGSTORE_NO_CACHE, and eliminates most
writes to disk from cosign outside of cosign initialize.
I think these tests are about equivalent to what we had before, if not
a bit better. The coverage is at 72% and hits most non-sporadic errors.
Signed-off-by: Dan Lorenc lorenc.d@gmail.com
Summary
Ticket Link
Fixes
Release Note