Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extract pub key from GitLab #941

Merged
merged 1 commit into from
Oct 26, 2021
Merged

Conversation

developer-guy
Copy link
Member

Signed-off-by: Batuhan Apaydın batuhan.apaydin@trendyol.com

Summary

If applied this PR will add support of extracting public key from GitLab.

Ticket Link

Fixes #939

Release Note

feat: extract pub key from GitLab

render1634924011414

Don't worry I already revoked the GitLab token :)

Copy link
Contributor

@hectorj2f hectorj2f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to regenerate the CLI docs.

@hectorj2f
Copy link
Contributor

It seems there is an extra whitespace

Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
Copy link
Contributor

@hectorj2f hectorj2f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :), thanks.

@developer-guy
Copy link
Member Author

lgtm :), thanks.

thank you so much @hectorj2f for all your review ❤️

@dlorenc dlorenc merged commit 7c48e9a into sigstore:main Oct 26, 2021
@github-actions github-actions bot added this to the v1.3.0 milestone Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

retrieve public key from GitLab via cosign public-key command
3 participants