Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rekor sharding guide #318

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

vipulagarwal
Copy link
Contributor

Summary

Fixes #314

The rekor sharding guide needs to be updated to account for the sigstore/rekor#864 introduced in Rekor and a note for users to use Trillian port 8091 for gRPC when using Sigstore helm charts.

Release Note

  • Rename TreeSize to ActiveTreeSize introduced as a breaking change in rekor PR #864
  • Add a note sigstore helm chart making use of port 8091 for gRPC

Documentation

This will require an update to documentation for rekor sharding guide: https://docs.sigstore.dev/logging/sharding/

  * Rename `TreeSize` to `ActiveTreeSize` introduced as a breaking change in
    rekor PR #864
  * Add a note sigstore helm chart making use of port 8091 for gRPC

Signed-off-by: Vipul Agarwal <va@vagarwal.net>
Copy link

netlify bot commented Jul 23, 2024

Deploy Preview for docssigstore ready!

Name Link
🔨 Latest commit 5a7da8a
🔍 Latest deploy log https://app.netlify.com/sites/docssigstore/deploys/669efb24eb96f200085949b9
😎 Deploy Preview https://deploy-preview-318--docssigstore.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@haydentherapper haydentherapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@haydentherapper haydentherapper merged commit 3a49fd9 into sigstore:main Jul 23, 2024
6 checks passed
@vipulagarwal vipulagarwal deleted the 314_fix_sharding_guide branch July 23, 2024 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rekor sharding guide needs updating
2 participants