Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make command require swagger cli #57

Closed
endorama opened this issue Mar 24, 2021 · 3 comments · Fixed by #63
Closed

make command require swagger cli #57

endorama opened this issue Mar 24, 2021 · 3 comments · Fixed by #63

Comments

@endorama
Copy link
Contributor

Trying to run make produce an error due to swagger not being found.

$ make
swagger generate server -f openapi.yaml -q -r COPYRIGHT.txt -t pkg/generated --exclude-main -A fulcio_server --exclude-spec --flag-strategy=pflag -P github.com/coreos/go-oidc/v3/oidc.IDToken
make: swagger: Command not found
Makefile:10: recipe for target 'pkg/generated/models/%.go' failed
make: *** [pkg/generated/models/%.go] Error 127

I'm not sure how I'm supposed to install it, I'd like some guidance. Happy to improve the docs with a PR.
Thanks!

@dlorenc
Copy link
Member

dlorenc commented Mar 24, 2021

Great point! There was some trickiness regarding exact versions before, but I'm not sure how much that matters now. Here's what our github actions code does to install it:

https://github.com/sigstore/fulcio/blob/development/.github/workflows/main.yml#L30

Does that work for you?

@endorama
Copy link
Contributor Author

Yes thanks! Should I make a PR to amend the docs?

@dlorenc
Copy link
Member

dlorenc commented Mar 25, 2021

Sure, if you're up for it!

tommyd450 pushed a commit to tommyd450/fulcio that referenced this issue Nov 7, 2023
chore: remove unit tests from RHTAP pipeline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants