[Correction] Upgrade fulcios to use of the google privateca api at v1 #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Scott Nichols <n3wscott@chainguard.dev>
Signed-off-by: Scott Nichols <n3wscott@chainguard.dev>
Signed-off-by: Scott Nichols <n3wscott@chainguard.dev>
Signed-off-by: Scott Nichols <n3wscott@chainguard.dev>
n3wscott
commented
Dec 1, 2021
| ca, err = googlecabeta.NewCertAuthorityService() | ||
| version := viper.GetString("gcp_private_ca_version") | ||
| switch version { | ||
| case "v1": |
There was a problem hiding this comment.
In the original pr, these where switches and no one caught it...
dlorenc
approved these changes
Dec 1, 2021
| ca, err = googlecabeta.NewCertAuthorityService() | ||
| version := viper.GetString("gcp_private_ca_version") | ||
| switch version { | ||
| case "v1": |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relands and corrects #218
Signed-off-by: Scott Nichols n3wscott@chainguard.dev
Summary
We were still on a v1beta1 api for the googleca private ca. This adds a flag to use the v1 of the api. We are still needing to update the cert to
v1.The new flag
--gcp_private_ca_versionselectsv1by default to allow us to drop the flag when we move to v1 certs and then delete the flag and the v1beta1 codepaths.Ticket Link
Relates to a checkbox in #191
Release Note