Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Correction] Upgrade fulcios to use of the google privateca api at v1 #252

Merged
merged 6 commits into from
Dec 1, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/api/ca.go
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,9 @@ func CA() certauth.CertificateAuthority {
version := viper.GetString("gcp_private_ca_version")
switch version {
case "v1":
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the original pr, these where switches and no one caught it...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooops!

ca, err = googlecav1beta1.NewCertAuthorityService()
case "v1beta1":
ca, err = googlecav1.NewCertAuthorityService()
case "v1beta1":
ca, err = googlecav1beta1.NewCertAuthorityService()
default:
err = fmt.Errorf("invalid value for gcp_private_ca_version: %v", version)
}
Expand Down