Move SPIFFE principal to its own package #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #604 +/- ##
==========================================
- Coverage 56.82% 56.62% -0.21%
==========================================
Files 23 24 +1
Lines 1552 1563 +11
==========================================
+ Hits 882 885 +3
- Misses 595 601 +6
- Partials 75 77 +2
Continue to review full report at Codecov.
|
haydentherapper
previously approved these changes
May 24, 2022
|
LGTM, there's a conflict |
Signed-off-by: Nathan Smith <nathan@chainguard.dev>
haydentherapper
approved these changes
May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Move the SPIFFE principal to its own package and out of challenge result