Refactor verification to use consistent verification options. #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes attached signature verification to respect the same options as detached signatures. - Adds tests for attached signature verification. - Exports useful functions to allow other libraries to validate commits. - Adds package documentation for what should go into git vs signature packages (because if I was getting getting tripped up, other people will too). - Removed found signature / found tlog entry claims - I'm not sure how useful these are on their own, and my gut instinct is the yes / no for the validation is probably sufficient. - Changes smimesign output in verification info to gitsign. Signed-off-by: Billy Lynch <billy@chainguard.dev>
imjasonh
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
detached signatures.
packages (because if I was getting getting tripped up, other people
will too).
useful these are on their own, and my gut instinct is the yes / no for
the validation is probably sufficient.
Signed-off-by: Billy Lynch billy@chainguard.dev
Ticket Link
Fixes #52
Release Note