Calculate correct SHA for signed Tags. #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were trying to marshal tags into commit objects, which go-git was happily doing, but ignoring non-matching fields. This change tries to detect whether we are signing a commit or tag and encode the matching type. Also updates README for more copy/paste instructions for signing tags. BREAKING CHANGE: Since this is fixing how the tag SHA was meant to be calculated, this breaks the rekor entry lookup for older versions that use the incorrect behavior. Those tags will be considered unverified unless they are resigned by a newer version of gitsign: `git tag -f -s <tag name>` Signed-off-by: Billy Lynch <billy@chainguard.dev>
imjasonh
approved these changes
Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously we were trying to marshal tags into commit objects, which
go-git was happily doing, but ignoring non-matching fields. This change
tries to detect whether we are signing a commit or tag and encode the
matching type.
Also updates README for more copy/paste instructions for signing tags.
BREAKING CHANGE: Since this is fixing how the tag SHA was meant to be
calculated, this breaks the rekor entry lookup for older versions that
use the incorrect behavior. Those tags will be considered unverified
unless they are resigned by a newer version of gitsign:
git tag -f -s <tag name> <tag name>Signed-off-by: Billy Lynch billy@chainguard.dev
Ticket Link
Fixes #88
Release Note