Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trustroot testdata generator and embedded data #1325

Merged
merged 5 commits into from
Mar 23, 2024

Conversation

codysoyland
Copy link
Member

Summary

This PR adds a small program to generate testdata for the trustroot reconciler tests, and uses go:embed to include the test data so that it is easier to read and maintain.

Fixes #1324

Release Note

Documentation

Signed-off-by: Cody Soyland <codysoyland@github.com>
Signed-off-by: Cody Soyland <codysoyland@github.com>
Signed-off-by: Cody Soyland <codysoyland@github.com>
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.25%. Comparing base (395638e) to head (f896651).
Report is 61 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1325      +/-   ##
==========================================
- Coverage   54.33%   54.25%   -0.08%     
==========================================
  Files          44       44              
  Lines        3839     3839              
==========================================
- Hits         2086     2083       -3     
- Misses       1539     1541       +2     
- Partials      214      215       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@hectorj2f hectorj2f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @codysoyland. Everything looks good here. Could you add a Makefile target that regenerates the test data?

Signed-off-by: Cody Soyland <codysoyland@github.com>
Signed-off-by: Cody Soyland <codysoyland@github.com>
Copy link
Collaborator

@hectorj2f hectorj2f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @codysoyland

@hectorj2f hectorj2f merged commit 46f0020 into sigstore:main Mar 23, 2024
75 of 76 checks passed
@github-actions github-actions bot added this to the v1 milestone Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add testdata generator for trustroot reconciler tests
3 participants