Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a configuration field to allow CIP with no authorities #292

Merged
merged 2 commits into from
Oct 7, 2022

Conversation

hectorj2f
Copy link
Collaborator

Signed-off-by: Hector Fernandez hector@chainguard.dev

Summary

This PR aims to expose a new configuration setting to allow creating CIP without authorities, as explained in #275.

related to: #275

Release Note

Documentation

@hectorj2f hectorj2f self-assigned this Oct 6, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2022

Codecov Report

Merging #292 (02b5fdc) into main (085aeb9) will increase coverage by 0.00%.
The diff coverage is 68.42%.

@@           Coverage Diff           @@
##             main     #292   +/-   ##
=======================================
  Coverage   62.36%   62.36%           
=======================================
  Files          30       30           
  Lines        2668     2684   +16     
=======================================
+ Hits         1664     1674   +10     
- Misses        916      922    +6     
  Partials       88       88           
Impacted Files Coverage Δ
cmd/policy_webhook/main.go 0.00% <0.00%> (ø)
...is/policy/v1beta1/clusterimagepolicy_validation.go 96.01% <100.00%> (+0.05%) ⬆️
pkg/config/store.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Hector Fernandez <hector@chainguard.dev>
Signed-off-by: Hector Fernandez <hector@chainguard.dev>
@hectorj2f hectorj2f marked this pull request as ready for review October 6, 2022 23:09
@hectorj2f hectorj2f changed the title WIP: add a configuration field to allow CIP with no authorities Add a configuration field to allow CIP with no authorities Oct 6, 2022
@hectorj2f hectorj2f requested a review from vaikas October 6, 2022 23:09
@hectorj2f hectorj2f added the enhancement New feature or request label Oct 6, 2022
Copy link
Collaborator

@vaikas vaikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants