cleanup: update repo to use cosign v2.0.0-rc.1 #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k4leung4
force-pushed
the
bump-cosign-b
branch
from
499e6b1
to
4e96305
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #535 +/- ##
=======================================
Coverage 54.79% 54.79%
=======================================
Files 42 42
Lines 4559 4559
=======================================
Hits 2498 2498
Misses 1856 1856
Partials 205 205 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
k4leung4
force-pushed
the
bump-cosign-b
branch
from
4e96305
to
2383ca7
Compare
Signed-off-by: Kenny Leung <kleung@chainguard.dev>
k4leung4
force-pushed
the
bump-cosign-b
branch
from
2383ca7
to
5f2afc1
Compare
hectorj2f
approved these changes
Jan 28, 2023
hectorj2f
reviewed
Jan 28, 2023
| @@ -119,7 +119,7 @@ echo '::endgroup::' | |||
| echo '::group:: Verify demoimage with cosign key and TSA' | |||
| export TSA_CERT_CHAIN=`kubectl -n tsa-system get secrets tsa-cert-chain -ojsonpath='{.data.cert-chain}'` | |||
| echo "$TSA_CERT_CHAIN" | base64 -d > tsa-cert-chain.pem | |||
| COSIGN_EXPERIMENTAL=1 cosign verify --key cosign.pub --timestamp-cert-chain tsa-cert-chain.pem --insecure-skip-tlog-verify --rekor-url ${REKOR_URL} --allow-insecure-registry ${demoimage} | |||
| COSIGN_EXPERIMENTAL=1 cosign verify --key cosign.pub --timestamp-cert-chain tsa-cert-chain.pem --insecure-ignore-tlog --rekor-url ${REKOR_URL} --allow-insecure-registry ${demoimage} | |||
There was a problem hiding this comment.
nit: we don't need COSIGN_EXPERIMENTAL
|
We can go with these changes #536. I'll remove the EXPERIMENTAL env variable in a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kenny Leung kleung@chainguard.dev
Summary
cleanup: update repo to use cosign v2.0.0-rc.1
Release Note
cleanup: update repo to use cosign v2.0.0-rc.1
Documentation