-
Notifications
You must be signed in to change notification settings - Fork 67
Bump cosign e2e tests to rc2.0.0.rc.1 #536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Kenny Leung <kleung@chainguard.dev>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #536 +/- ##
=======================================
Coverage 54.79% 54.79%
=======================================
Files 42 42
Lines 4559 4559
=======================================
Hits 2498 2498
Misses 1856 1856
Partials 205 205 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Hector Fernandez <hector@chainguard.dev>
cf2f0c7 to
1298673
Compare
test/testdata/policy-controller/e2e/cip-key-signature-pull-secrets.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Hector Fernandez <hector@chainguard.dev>
|
I don't think we should be bumping the copyrights in all the files, at least everywhere else they get put in when the file is created and they don't get bumped each year. |
Signed-off-by: Hector Fernandez <hector@chainguard.dev>
45a46fa to
78bb57d
Compare
I dropped the commit! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great! just a couple nits
| echo '::group:: Sign demoimage2 with key, and add to rekor and TSA' | ||
| export TSA_URL=`kubectl -n tsa-system get ksvc tsa -ojsonpath='{.status.url}'` | ||
| COSIGN_EXPERIMENTAL=1 COSIGN_PASSWORD="" cosign sign --key cosign.key --allow-insecure-registry --rekor-url ${REKOR_URL} --timestamp-server-url ${TSA_URL} ${demoimage2} | ||
| COSIGN_EXPERIMENTAL=1 COSIGN_YES="true" COSIGN_PASSWORD="" cosign sign --key cosign.key --allow-insecure-registry --rekor-url ${REKOR_URL} --timestamp-server-url ${TSA_URL} ${demoimage2} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe remove COSIGN_EXPERIMENTAL everywhere since it doesn't do anything anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that will be done in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Hector Fernandez <hector@chainguard.dev>
78bb57d to
f349fd6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this!
Summary
continuation of #535
Release Note
Documentation