Skip to content

Conversation

@hectorj2f
Copy link
Collaborator

Summary

continuation of #535

Release Note

Documentation

Signed-off-by: Kenny Leung <kleung@chainguard.dev>
@hectorj2f hectorj2f self-assigned this Jan 28, 2023
@hectorj2f hectorj2f requested review from k4leung4 and vaikas January 28, 2023 17:29
@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2023

Codecov Report

Merging #536 (f349fd6) into main (a2dfbb7) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #536   +/-   ##
=======================================
  Coverage   54.79%   54.79%           
=======================================
  Files          42       42           
  Lines        4559     4559           
=======================================
  Hits         2498     2498           
  Misses       1856     1856           
  Partials      205      205           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Hector Fernandez <hector@chainguard.dev>
Signed-off-by: Hector Fernandez <hector@chainguard.dev>
@hectorj2f hectorj2f requested a review from cpanato January 28, 2023 18:51
@vaikas
Copy link
Collaborator

vaikas commented Jan 28, 2023

I don't think we should be bumping the copyrights in all the files, at least everywhere else they get put in when the file is created and they don't get bumped each year.

Signed-off-by: Hector Fernandez <hector@chainguard.dev>
@hectorj2f hectorj2f force-pushed the bump-cosign-b branch 2 times, most recently from 45a46fa to 78bb57d Compare January 28, 2023 19:57
@hectorj2f
Copy link
Collaborator Author

I don't think we should be bumping the copyrights in all the files, at least everywhere else they get put in when the file is created and they don't get bumped each year.

I dropped the commit!

priyawadhwa
priyawadhwa previously approved these changes Jan 28, 2023
Copy link
Collaborator

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! just a couple nits

echo '::group:: Sign demoimage2 with key, and add to rekor and TSA'
export TSA_URL=`kubectl -n tsa-system get ksvc tsa -ojsonpath='{.status.url}'`
COSIGN_EXPERIMENTAL=1 COSIGN_PASSWORD="" cosign sign --key cosign.key --allow-insecure-registry --rekor-url ${REKOR_URL} --timestamp-server-url ${TSA_URL} ${demoimage2}
COSIGN_EXPERIMENTAL=1 COSIGN_YES="true" COSIGN_PASSWORD="" cosign sign --key cosign.key --allow-insecure-registry --rekor-url ${REKOR_URL} --timestamp-server-url ${TSA_URL} ${demoimage2}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe remove COSIGN_EXPERIMENTAL everywhere since it doesn't do anything anymore?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that will be done in a separate PR.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Hector Fernandez <hector@chainguard.dev>
Copy link
Collaborator

@vaikas vaikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@vaikas vaikas merged commit 229cde1 into sigstore:main Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants