Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(*models.Error) is not supported by the TextConsumer #1115

Closed
ianlewis opened this issue Oct 11, 2022 · 5 comments
Closed

(*models.Error) is not supported by the TextConsumer #1115

ianlewis opened this issue Oct 11, 2022 · 5 comments
Labels
bug Something isn't working

Comments

@ianlewis
Copy link

ianlewis commented Oct 11, 2022

We're seeing this error in a non-trivial number of our e2e test runs w/ slsa-github-generator.

&{0 } (*models.Error) is not supported by the TextConsumer, can be resolved by supporting TextUnmarshaler interface

As with #801 it seems to be a transient error. A quick Google search returned go-swagger/go-swagger#1929 which seems to be unresolved in the swagger library but there are some clues there as to potential ways to work around it.

@ianlewis ianlewis added the bug Something isn't working label Oct 11, 2022
@bobcallaway
Copy link
Member

I'm suspect that you're getting a 429 response due to rate limiting, but since that is formatted by nginx as HTML (instead of JSON which is what the rekor client expects by default).

be91b71 (which is in 1.0rc) changes the underlying HTTP client to quietly attempt retries according to the Retry-After headers returned by the gateway). That probably won't definitively fix the error you're reporting here, but should make it happen drastically less often.

@bobcallaway
Copy link
Member

@ianlewis has upgrading to rekor v1.0.0 helped in this?

@ianlewis
Copy link
Author

@bobcallaway I think we're still evaluating. I don't think we have a release with it included but I'll see how often it occurs in our e2e tests this week.

@ianlewis
Copy link
Author

@bobcallaway We actually didn't update Rekor to 1.0.0 in in slsa-github-generator yet. We only had updated it in the verifier. Hopefully slsa-framework/slsa-github-generator#1121 will get merged in the next day or so and we'll see results.

@ianlewis
Copy link
Author

ianlewis commented Nov 14, 2022

We've upgraded to rekor 1.0 and haven't seen this error since upgrading. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants