Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Rekor to v1.0.0 #1121

Merged
merged 4 commits into from
Oct 26, 2022
Merged

Update Rekor to v1.0.0 #1121

merged 4 commits into from
Oct 26, 2022

Conversation

ianlewis
Copy link
Member

Updates #959
Related sigstore/rekor#1115

Signed-off-by: Ian Lewis ianlewis@google.com

@ianlewis
Update Rekor to v1.0.0
fb7e701 
Signed-off-by: Ian Lewis <ianlewis@google.com>
@ianlewis
run go mod tidy
c47f951 
Signed-off-by: Ian Lewis <ianlewis@google.com>
@ianlewis ianlewis mentioned this pull request Oct 23, 2022
Closed
@ianlewis ianlewis enabled auto-merge (squash) October 24, 2022 13:41
@asraa
Copy link
Collaborator

asraa commented Oct 24, 2022

QQ: Can you update this line

slsa-github-generator/signing/sigstore/rekor.go

Line 63 in dfea9e3

rekorClient, err := rekor.NewClient(r.rekorAddr)

to pull client.GetRekorClient instead? Otherwise cosign hasn't necessarily updated with the retryable client. And we might as well get rid of the cosign dep and use it directly.
https://github.com/sigstore/rekor/blob/7807d1e5a3fbc9b8fdd17053da8163463e87a5ae/pkg/client/rekor_client.go#L28

@ianlewis ianlewis merged commit e23719f into slsa-framework:main Oct 26, 2022
@ianlewis
Copy link
Member Author

Oops, didn't realize auto-merge was enabled. Will submit a follow up PR.

@ianlewis ianlewis mentioned this pull request Oct 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurentsimon laurentsimon laurentsimon approved these changes

@asraa asraa Awaiting requested review from asraa

@joshuagl joshuagl Awaiting requested review from joshuagl joshuagl is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ianlewis @asraa @laurentsimon