Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] Improve handling of transient errors #959

Closed
ianlewis opened this issue Oct 5, 2022 · 3 comments
Closed

[feature] Improve handling of transient errors #959

ianlewis opened this issue Oct 5, 2022 · 3 comments
Labels
status:help wanted Extra attention is needed type:feature New feature or request type:refactor A cleanup or refactor
Milestone
Sigstore Stabilit...

Comments

@ianlewis
Copy link
Member

ianlewis commented Oct 5, 2022

Rekor and Fulcio may have transient errors and we can perhaps handle those better by retrying requests.
@ianlewis ianlewis added the type:feature New feature or request label Oct 5, 2022
@ianlewis ianlewis mentioned this issue Oct 5, 2022
Closed
@ianlewis ianlewis added status:help wanted Extra attention is needed type:refactor A cleanup or refactor labels Oct 6, 2022
@ianlewis
Copy link
Member Author

Per sigstore/rekor#1115 if we update to Rekor 1.0rc or later then we can use the rekor client that performs retries (apparently 4 times by default).

@ianlewis ianlewis added this to the 2022 Stability improvements milestone Oct 12, 2022
This was referenced Oct 13, 2022
Merged
Closed
@ianlewis
Copy link
Member Author

Updating to Rekor 1.0 should fix this once we do that.

@ianlewis ianlewis mentioned this issue Oct 23, 2022
Merged
@ianlewis
Copy link
Member Author

ianlewis commented Dec 2, 2022

We haven't had any e2e test failures due to transient errors with Rekor for a while. Closing.

@ianlewis ianlewis closed this as completed Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:help wanted Extra attention is needed type:feature New feature or request type:refactor A cleanup or refactor
Projects
None yet
Milestone
Sigstore Stability Improvements
Development

No branches or pull requests
1 participant
@ianlewis