remove double encoding of payload and signature fields for intoto v0.0.2 #1150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bob Callaway <bcallaway@google.com>
priyawadhwa
approved these changes
Oct 25, 2022
priyawadhwa
approved these changes
Oct 25, 2022
asraa
approved these changes
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intoto v0.0.2 type was defined with a hint to the code generation tool used in
rekor-cli&rekor-serverthat indicated that these strings were base64 encoded (this caused the code generated to handle encoding and decoding to/from[]byteslices). However,CreateArtifactFromPropsunnecessarily double encoded uploads to Rekor (that originated fromrekor-clior any caller ofCreateArtifactFromProps).This patch removes that hint to the code generation tool, leaving the field to be handled internally as a
stringrather thanstrfmt.Base64, while still supporting either single or double encoded entries to provide backwards compatibility for released clients.Fixes: #1139
Signed-off-by: Bob Callaway bcallaway@google.com