-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TLS support for Redis Client implementation #1998
Conversation
7d3ad6b
to
a3f1d2d
Compare
8bf3d19
to
fe9b0a5
Compare
cf774fb
to
4f51574
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1998 +/- ##
===========================================
- Coverage 66.46% 48.86% -17.60%
===========================================
Files 92 80 -12
Lines 9258 6626 -2632
===========================================
- Hits 6153 3238 -2915
- Misses 2359 2982 +623
+ Partials 746 406 -340
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
8611688
to
a0c712d
Compare
I think this should be ready to merge once the last comment is addressed - thanks for all the help on this :) |
947ccfc
to
191f24a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also needs to be set in
rekor/pkg/indexstorage/redis/redis.go
Line 45 in d596e9d
// by converting all characters into a lowercase value before looking up in Redis |
Signed-off-by: Mihkel Pärna <mihkel.parna@transferwise.com>
…allow skipping TLS verification Signed-off-by: Mihkel Pärna <mihkel.parna@transferwise.com>
…endpoint Signed-off-by: Mihkel Pärna <mihkel.parna@transferwise.com>
Signed-off-by: Mihkel Pärna <mihkel.parna@transferwise.com>
… implementations based on 'enable-tls' flag Signed-off-by: Mihkel Pärna <mihkel.parna@transferwise.com>
…conform to go best practices. Signed-off-by: Mihkel Pärna <mihkel.parna@transferwise.com>
Signed-off-by: Mihkel Pärna <mihkel.parna@transferwise.com>
Signed-off-by: Mihkel Pärna <mihkel.parna@transferwise.com>
39a4ae0
to
3b7485d
Compare
Something along the lines of this -> 3b7485d ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Summary
Adds support for using TLS when establishing a Redis Client. This becomes a mandatory step when using systems like Elasticache that enforce client TLS when set up to run in a Multi-AZ way.
Release Note
insecureSkipVerify
flag, closes Missing TLS support for Redis Client #1999 issueDocumentation