disable codeql on terraform-only changes #751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bob Callaway <bcallaway@google.com>
cpanato
approved these changes
Sep 7, 2023
k4leung4
approved these changes
Sep 7, 2023
cpanato
requested changes
Sep 7, 2023
| @@ -7,6 +7,8 @@ on: | |||
| pull_request: | |||
| branches: | |||
| - main | |||
| paths-ignore: | |||
| - 'terraform/**' | |||
There was a problem hiding this comment.
humm that will not run and the check that is required will not be valid and will block
we should use the dorny/paths-filter@v2 to filter then that will properly skip the job
There was a problem hiding this comment.
hmm, its worked across other workflows in this repo....... I guess I don't understand the difference?
There was a problem hiding this comment.
Oh really? That is good news then GitHub changed that behavior nice
cpanato
approved these changes
Sep 7, 2023
codysoyland
added a commit
that referenced
this pull request
Sep 15, 2023
This reverts commit 4d6984b. Branch protection rules require the CodeQL check. Signed-off-by: Cody Soyland <codysoyland@github.com>
codysoyland
added a commit
that referenced
this pull request
Sep 15, 2023
* Revert "disable codeql on terraform-only changes (#751)" This reverts commit 4d6984b. Branch protection rules require the CodeQL check. Signed-off-by: Cody Soyland <codysoyland@github.com> * Filter paths for CodeQL Signed-off-by: Cody Soyland <codysoyland@github.com> --------- Signed-off-by: Cody Soyland <codysoyland@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Release Note
Documentation