Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CodeQL path filtering #758

Merged
merged 2 commits into from Sep 15, 2023
Merged

Fix CodeQL path filtering #758

merged 2 commits into from Sep 15, 2023

Conversation

codysoyland
Copy link
Member

@codysoyland codysoyland commented Sep 15, 2023 •
edited

This reverts commit 4d6984b.

Branch protection rules require the CodeQL check. This change uses dorny/paths-filter@v2 to filter the path as a step in the workflow so that the required check still runs.

This blocks #757 which is a terraform-only change.

Signed-off-by: Cody Soyland codysoyland@github.com

@codysoyland
Revert "disable codeql on terraform-only changes (#751)"
22a1c1f 
This reverts commit 4d6984b.
Branch protection rules require the CodeQL check.

Signed-off-by: Cody Soyland <codysoyland@github.com>
@cpanato
Copy link
Member

cpanato commented Sep 15, 2023

we need to use this action to filter out #751 (comment)

i can submit a PR later

@codysoyland
Copy link
Member Author

we need to use this action to filter out #751 (comment)

i can submit a PR later

Good call, I can do it in this PR actually.

@codysoyland
Filter paths for CodeQL
6d0e5d1 
Signed-off-by: Cody Soyland <codysoyland@github.com>
@codysoyland codysoyland changed the title Revert "disable codeql on terraform-only changes (#751)" Fix CodeQL path filtering Sep 15, 2023
cpanato
cpanato approved these changes Sep 15, 2023
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@codysoyland
Copy link
Member Author

@cpanato Do you understand why the bare CodeQL status check on this PR is not running? I don't know where that came from, as the CodeQL / Analyze (go) check is running/passing.

@codysoyland codysoyland enabled auto-merge (squash) September 15, 2023 18:52
@cpanato
Copy link
Member

cpanato commented Sep 15, 2023

@cpanato Do you understand why the bare CodeQL status check on this PR is not running? I don't know where that came from, as the CodeQL / Analyze (go) check is running/passing.

we will need to update that, gimme a sec

@cpanato cpanato mentioned this pull request Sep 15, 2023
Merged
@cpanato
Copy link
Member

cpanato commented Sep 15, 2023

lets do this: sigstore/community#321

and later I will run a test pr to check others requires that we can add, lets apply that to unblock you

@bobcallaway
Copy link
Member

Thanks all, i appreciate you cleaning up my mistake

@codysoyland codysoyland merged commit fb23047 into main Sep 15, 2023
16 checks passed
@codysoyland codysoyland deleted the codeql-required-check branch September 15, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@bobcallaway bobcallaway Awaiting requested review from bobcallaway

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@codysoyland @cpanato @bobcallaway