-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build-logic to make adding new modules easier #101
Conversation
e93853b
to
e8c3fde
Compare
Sorry for force-push storm. I just realized that I should move |
Signed-off-by: Vladimir Sitnikov <sitnikov.vladimir@gmail.com>
8accef5
to
0010103
Compare
There's a recent idea to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm having a hard time following this, sorry to ask you to break this up again. I think what would make this easier for is to just create the new dir structure without build logic updates.
/sigstore-java/sigstore-java.
The build-logic seem to apply pretty strongly to a gradle plugin? But maybe I'm misunderstanding it.
We could do build logic updates in a new PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just a few comments.
build-logic/publishing/src/main/kotlin/build-logic.publish-to-central.gradle.kts
Show resolved
Hide resolved
Signed-off-by: Vladimir Sitnikov <sitnikov.vladimir@gmail.com>
I must have missed this. I believe this PR adds only the bits that are required to build |
If this is ready to go, I'll merge it? |
Go ahead |
Summary
This moves sigstore-java sources to
sigstore-java
folder. The move itself is done in a separate commit to make review easier.Release Note
Documentation
WDYT?