Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build-logic to make adding new modules easier #101

Merged
merged 2 commits into from
Sep 7, 2022

Conversation

vlsi
Copy link
Collaborator

@vlsi vlsi commented Sep 2, 2022

Summary

This moves sigstore-java sources to sigstore-java folder. The move itself is done in a separate commit to make review easier.

Release Note

  • Added build-logic to make adding new modules easier

Documentation

WDYT?

@vlsi
Copy link
Collaborator Author

vlsi commented Sep 2, 2022

Sorry for force-push storm. I just realized that I should move /build.gradle.kts -> /sigstore-java/build.gradle.kts before adding build logic.
Then Git realizes that /build.gradle.kts with added build logic is a brand new file, and it shows a better history for /sigstore-java/build.gradle.kts

Signed-off-by: Vladimir Sitnikov <sitnikov.vladimir@gmail.com>
build-logic/jvm/build.gradle.kts Outdated Show resolved Hide resolved
@vlsi vlsi force-pushed the add_buildlogic branch 3 times, most recently from 8accef5 to 0010103 Compare September 3, 2022 20:44
@vlsi
Copy link
Collaborator Author

vlsi commented Sep 6, 2022

There's a recent idea to use /gradle/plugins folder instead of /build-logic: gradle/gradle#21192

Copy link
Member

@loosebazooka loosebazooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm having a hard time following this, sorry to ask you to break this up again. I think what would make this easier for is to just create the new dir structure without build logic updates.
/sigstore-java/sigstore-java.

The build-logic seem to apply pretty strongly to a gradle plugin? But maybe I'm misunderstanding it.

We could do build logic updates in a new PR.

loosebazooka
loosebazooka previously approved these changes Sep 7, 2022
Copy link
Member

@loosebazooka loosebazooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just a few comments.

Signed-off-by: Vladimir Sitnikov <sitnikov.vladimir@gmail.com>
@vlsi
Copy link
Collaborator Author

vlsi commented Sep 7, 2022

I think what would make this easier for is to just create the new dir structure without build logic updates.
The build-logic seem to apply pretty strongly to a gradle plugin? But maybe I'm misunderstanding it.

I must have missed this.

I believe this PR adds only the bits that are required to build sigstore-java, and the build logic updates for building Gradle plugin are not here (they go in the last commit of #98)

@loosebazooka
Copy link
Member

If this is ready to go, I'll merge it?

@vlsi
Copy link
Collaborator Author

vlsi commented Sep 7, 2022

Go ahead

@loosebazooka loosebazooka merged commit 200d266 into sigstore:main Sep 7, 2022
@vlsi vlsi deleted the add_buildlogic branch September 7, 2022 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants