Use spec-compliant persisted target filenames #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Appu Goundan <appu@google.com>
vlsi
reviewed
Apr 4, 2023
| @@ -420,7 +420,10 @@ void downloadTargets(Targets targets) | |||
| throw new FileNotFoundException(targetName, fetcher.getSource()); | |||
| } | |||
| verifyHashes(entry.getKey(), targetBytes, targetData.getHashes()); | |||
| localStore.storeTargetFile(versionedTargetName, targetBytes); | |||
|
|
|||
| // when persisting targets use the targetname without sha512 prefix | |||
There was a problem hiding this comment.
The link you mention suggests checksum-prefixed names for consistent snapshots scheme. Why we should skip checksums here?
There was a problem hiding this comment.
This is the relevant line of the link:
In either case, the client MUST write the file to non-volatile storage as FILENAME.EXT.
The code already does fetch by the checksummed prefixed name (versionedTargetName), but we write without the prefix.
patflynn
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@asraa recently informed me that we shouldn't be persisting down to disk (or wherever) with the sha prefixed filename.
context: https://theupdateframework.github.io/specification/latest/index.html#fetch-target