change default Rekor entry type for intoto attestations to 'dsse' #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bob Callaway <bcallaway@google.com>
Signed-off-by: Bob Callaway <bcallaway@google.com>
🦋 Changeset detectedLatest commit: 50b8877 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@bobcallaway thanks for all the work on the support for the new Rekor type. For the npm use case we still have some work to do on the registry to support the |
|
With the recent refactoring of the signing logic, this PR is no longer valid. I'm going to close it in favor of #631 which does the same thing (changes the default Rekor type from "intoto" to "dsse") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #526
Summary
This causes uploads to Rekor for intoto attestations to use the newly-added
dssetype instead of theintoto:0.0.2type. In addition to being simpler to deal with, Rekor will not persist the attestations fordsseentries.Release Note
Uploads to Rekor for intoto attestations now use the
dsseRekor type, which will result in the attestation not being stored by Rekor.