Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat : Fuzzing #146

Merged
merged 2 commits into from
Nov 17, 2021
Merged

Conversation

naveensrinivasan
Copy link
Contributor

Enabling fuzzing for sigstore.

The first steps into fuzzing Sigstore.
The goal is to integrate this into oss-fuzz using libfuzzer
https://google.github.io/oss-fuzz/getting-started/new-project-guide/go-lang/ and
https://security.googleblog.com/2021/11/clusterfuzzlite-continuous-fuzzing-for.html

Signed-off-by: naveen 172697+naveensrinivasan@users.noreply.github.com

@naveensrinivasan
Copy link
Contributor Author

I was trying to enable fuzzing of https://github.com/sigstore/rekor ran into the tight coupling of the code and realized the ideal place to start is sigstore which is a library.

@lukehinds
Copy link
Member

nice! thanks

could this be leveraged as a github action as well?

@bobcallaway
Copy link
Member

+1 to the concept - @cpanato do you think it makes to implement the same hack/tools pattern in this repo as we did in rekor & fulcio?

@naveensrinivasan
Copy link
Contributor Author

nice! thanks

could this be leveraged as a github action as well?

Yes, my thought process is crawl-walk-run. I wanted to get the initial set up done run ClusterFuzz lite as part of GitHub action for every PR and also probably as a corn job

@naveensrinivasan
Copy link
Contributor Author

+1 to the concept - @cpanato do you think it makes to implement the same hack/tools pattern in this repo as we did in rekor & fulcio?

I agree that would be good. But can that be a refactor after this one is merged?

test/fuzz/corpus/0 Outdated Show resolved Hide resolved
@@ -0,0 +1,2 @@
-----BEGIN -----
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put the initial corpus into the workdir/corpus directory (in our case examples/png/corpus). Go-fuzz will add own inputs to the corpus directory. Consider committing the generated inputs to your source control system, this will allow you to restart go-fuzz without losing previous work.
Source https://github.com/dvyukov/go-fuzz
https://github.com/dvyukov/go-fuzz-corpus/tree/master/pem/corpus

Enabling fuzzing for sigstore.

The first steps into fuzzing Sigstore.
The goal is to integrate this into oss-fuzz using libfuzzer
https://google.github.io/oss-fuzz/getting-started/new-project-guide/go-lang/ and
https://security.googleblog.com/2021/11/clusterfuzzlite-continuous-fuzzing-for.html

Signed-off-by: naveen <172697+naveensrinivasan@users.noreply.github.com>
@naveensrinivasan
Copy link
Contributor Author

@lukehinds @dlorenc Friendly ping.

Copy link
Member

@bobcallaway bobcallaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit otherwise LGTM

Makefile Outdated Show resolved Hide resolved
Co-authored-by: Bob Callaway <bobcallaway@users.noreply.github.com>
@naveensrinivasan
Copy link
Contributor Author

one nit otherwise LGTM

Thanks! Merged the suggestion.

@bobcallaway bobcallaway merged commit c2fea24 into sigstore:main Nov 17, 2021
@naveensrinivasan naveensrinivasan deleted the naveen/feat/refactor branch November 17, 2021 16:17
@cpanato
Copy link
Member

cpanato commented Nov 22, 2021

+1 to the concept - @cpanato do you think it makes to implement the same hack/tools pattern in this repo as we did in rekor & fulcio?

will do and propose a PR, sorry for the delay to reply, missed this notification

mtrmac pushed a commit to mtrmac/sigstore that referenced this pull request Mar 10, 2023
* Add support for COSIGN_REPOSITORY env var

This env var will allow users to specify which repo they want cosign signatures stored in.

Signed-off-by: Priya Wadhwa <priyawadhwa@google.com>

* Add notes about COSIGN_REPOSITORY to README

Signed-off-by: Priya Wadhwa <priyawadhwa@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants