move e2e tests inline with various implementation packages #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bob Callaway <bob.callaway@gmail.com>
haydentherapper
previously approved these changes
Feb 18, 2022
| @@ -13,9 +13,10 @@ | |||
| // See the License for the specific language governing permissions and | |||
| // limitations under the License. | |||
|
|
|||
| //go:build e2e | |||
| // +build e2e | |||
There was a problem hiding this comment.
Is this comment used?
There was a problem hiding this comment.
vscode must have added it, i didnt do it intentionally.
There was a problem hiding this comment.
Yeah it's a new thing in go 1.16.
Signed-off-by: Bob Callaway <bob.callaway@gmail.com>
dlorenc
approved these changes
Feb 18, 2022
mtrmac
pushed a commit
to mtrmac/sigstore
that referenced
this pull request
Mar 10, 2023
…#282) Bumps [github.com/open-policy-agent/opa](https://github.com/open-policy-agent/opa) from 0.27.1 to 0.28.0. - [Release notes](https://github.com/open-policy-agent/opa/releases) - [Changelog](https://github.com/open-policy-agent/opa/blob/main/CHANGELOG.md) - [Commits](open-policy-agent/opa@v0.27.1...v0.28.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the e2e tests into the provider-specific packages and also removes the need for monkey patching since the oauthflow test can mock the package-internal variable for opening a browser.
Signed-off-by: Bob Callaway bob.callaway@gmail.com