Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tag,key_ring,key optional for release workflow. #338

Merged
merged 1 commit into from
Mar 21, 2022

Conversation

k4leung4
Copy link
Contributor

Signed-off-by: Kenny Leung kleung@chainguard.dev

Summary

Make tag,key_ring,key optional for release workflow.

This is make it possible to cut releases completely automatically.

The tag will now increment the patch value by one if the release tag is
not specified.
For example:

  • 1.5.9 => 1.5.10

Keyring and Key value from GCP project are now hardcoded.

Will remove the input key_ring and key when it dependent workflows are
updated to no longer specify them.

Ticket Link

Fixes

towards fixing https://github.com/sigstore/public-good-instance/issues/50

Release Note


This is make it possible to cut releases completely automatically.

The tag will now increment the patch value by one if the release tag is
not specified.
For example:
- 1.5.9 => 1.5.10

Keyring and Key value from GCP project are now hardcoded.

Will remove the input key_ring and key when it dependent workflows are
updated to no longer specify them.

Signed-off-by: Kenny Leung <kleung@chainguard.dev>
@k4leung4
Copy link
Contributor Author

@cpanato please review.

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for sigstore/sigstore we don't have a cloudbuild, we just tag the repository and create a GitHub release.
i think I did not pay attention much here #325 :(

maybe for sigstore/sigtore we can have a workflow just to create the GH and push the changelog

@k4leung4
Copy link
Contributor Author

for sigstore/sigstore we don't have a cloudbuild, we just tag the repository and create a GitHub release. i think I did not pay attention much here #325 :(

maybe for sigstore/sigtore we can have a workflow just to create the GH and push the changelog

Agree. sigstore/sigstore will need it's own release workflow.
This workflow was meant for reuse in cosign, rekor and fulcio.

@cpanato
Copy link
Member

cpanato commented Mar 21, 2022

for sigstore/sigstore we don't have a cloudbuild, we just tag the repository and create a GitHub release. i think I did not pay attention much here #325 :(
maybe for sigstore/sigtore we can have a workflow just to create the GH and push the changelog

Agree. sigstore/sigstore will need it's own release workflow. This workflow was meant for reuse in cosign, rekor and fulcio.

ahh true, sorry Monday.... 🤦

@dlorenc dlorenc merged commit 3fdc0b9 into sigstore:main Mar 21, 2022
mtrmac pushed a commit to mtrmac/sigstore that referenced this pull request Mar 10, 2023
Bumps [github.com/google/go-cmp](https://github.com/google/go-cmp) from 0.5.5 to 0.5.6.
- [Release notes](https://github.com/google/go-cmp/releases)
- [Commits](google/go-cmp@v0.5.5...v0.5.6)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants