Move kms package from cosign to sigstore #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me code Signed-off-by: Priya Wadhwa <priyawadhwa@google.com>
dekkagaijin
approved these changes
Apr 14, 2021
dlorenc
approved these changes
Apr 14, 2021
mtrmac
pushed a commit
to mtrmac/sigstore
that referenced
this pull request
Mar 10, 2023
Readme updates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way both cosign and rekor can use the code, and it's cleaner than rekor having to import from cosign itself. I directly copied this package over: https://github.com/sigstore/cosign/tree/main/pkg/cosign/kms
Next step: remove this code from cosign
Signed-off-by: Priya Wadhwa priyawadhwa@google.com