Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add formatted URL for rekor entry #80

Merged
merged 3 commits into from
Jul 6, 2021
Merged

Conversation

lukehinds
Copy link
Member

Also remove signingCert.Subject which returns an empty result

image

Signed-off-by: Luke Hinds lhinds@redhat.com

Also remove signingCert.Subject which returns an empty result

Signed-off-by: Luke Hinds <lhinds@redhat.com>
bobcallaway
bobcallaway previously approved these changes Jul 6, 2021
cmd/sign.go Outdated Show resolved Hide resolved
cpanato
cpanato previously approved these changes Jul 6, 2021
@cpanato
Copy link
Member

cpanato commented Jul 6, 2021

need rebase with the latest main branch

Luke Hinds added 2 commits July 6, 2021 15:25
Signed-off-by: Luke Hinds <lhinds@redhat.com>
Signed-off-by: Luke Hinds <lhinds@redhat.com>
@lukehinds lukehinds dismissed stale reviews from cpanato and bobcallaway via 4f0dd1c July 6, 2021 14:27
@lukehinds lukehinds merged commit 189266d into sigstore:main Jul 6, 2021
mtrmac pushed a commit to mtrmac/sigstore that referenced this pull request Mar 10, 2023
* enabled 'set -ex' in e2etest (was ignoring failing cmd)
* updated install instructions

Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants