Add intermediate and root verify flags #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Meredith Lancaster <malancas@github.com>
Signed-off-by: Meredith Lancaster <malancas@github.com>
Signed-off-by: Meredith Lancaster <malancas@github.com>
Codecov Report
@@ Coverage Diff @@
## main #180 +/- ##
==========================================
- Coverage 48.17% 46.81% -1.37%
==========================================
Files 18 18
Lines 1067 1098 +31
==========================================
Hits 514 514
- Misses 495 526 +31
Partials 58 58
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
malancas
commented
Dec 9, 2022
| outputContains(t, out, "Successfully verified timestamp") | ||
| } | ||
|
|
||
| func TestVerifyPassLeafCertificate(t *testing.T) { | ||
| func TestVerify_RootAndIntermediateCertificateFlags(t *testing.T) { |
There was a problem hiding this comment.
I think we can rewrite all or most of these verify tests as table tests in a follow up PR.
Signed-off-by: Meredith Lancaster <malancas@github.com>
haydentherapper
previously approved these changes
Dec 9, 2022
Co-authored-by: Hayden B <hblauzvern@gmail.com> Signed-off-by: Meredith Lancaster <malancas@users.noreply.github.com>
Co-authored-by: Hayden B <hblauzvern@gmail.com> Signed-off-by: Meredith Lancaster <malancas@users.noreply.github.com>
haydentherapper
previously approved these changes
Dec 9, 2022
Signed-off-by: Meredith Lancaster <malancas@github.com>
haydentherapper
approved these changes
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #121
Release Note
Add
--root-certificatesand--intermediate-certificatesflags to the verify command. The client can now either pass intermediate and root certificates together using the--certificate-chainflag or separately using these two new flags.Documentation