Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default NTP monitoring configuration #186

Merged
merged 7 commits into from
Dec 15, 2022

Conversation

malancas
Copy link
Contributor

@malancas malancas commented Dec 14, 2022

Summary

Closes #164

The server now uses the default NTP monitoring configuration by default. This change also enables NTP monitoring on by default. A new --disable-ntp-monitoring flag has been added to disable NTP monitoring.

Release Note

Documentation

Signed-off-by: Meredith Lancaster <malancas@github.com>
Signed-off-by: Meredith Lancaster <malancas@github.com>
@malancas malancas requested a review from a team as a code owner December 14, 2022 15:06
@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2022

Codecov Report

Merging #186 (3407b94) into main (986d973) will decrease coverage by 0.03%.
The diff coverage is 27.27%.

@@            Coverage Diff             @@
##             main     #186      +/-   ##
==========================================
- Coverage   47.81%   47.77%   -0.04%     
==========================================
  Files          18       18              
  Lines        1119     1124       +5     
==========================================
+ Hits          535      537       +2     
- Misses        528      529       +1     
- Partials       56       58       +2     
Impacted Files Coverage Δ
pkg/ntpmonitor/config.go 37.50% <27.27%> (+1.13%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Meredith Lancaster <malancas@github.com>
Signed-off-by: Meredith Lancaster <malancas@github.com>
Signed-off-by: Meredith Lancaster <malancas@github.com>
pkg/ntpmonitor/config.go Show resolved Hide resolved
cmd/timestamp-server/app/root.go Outdated Show resolved Hide resolved
Signed-off-by: Meredith Lancaster <malancas@github.com>
Co-authored-by: Hayden B <hblauzvern@gmail.com>
Signed-off-by: Meredith Lancaster <malancas@users.noreply.github.com>
@haydentherapper haydentherapper merged commit 2df80ed into sigstore:main Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default to NTP monitoring being on
4 participants