v1.4.1-HMR for review #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eview_reload Live reloading LiveViews without a hard refresh
KyosukeUryu
commented
Feb 17, 2023
Comment on lines
+58
to
+66
| for {topic, patterns} <- notify_patterns do | ||
| if matches_any_pattern?(path, patterns) do | ||
| Phoenix.PubSub.broadcast( | ||
| socket.pubsub_server, | ||
| to_string(topic), | ||
| {:phoenix_live_reload, topic, path} | ||
| ) | ||
| end | ||
| end |
There was a problem hiding this comment.
基本的には:notifyオプションの追加でnotify_patternsからPubSubで他のappにも通知できるようになったのが主な修正のようでした。
PR見た感じ:phoenix_live_viewで利用できるように拡張したらしい
phoenixframework#131
KyosukeUryu
commented
Feb 17, 2023
| * `:debounce` - an integer in milliseconds to wait before sending | ||
| live reload events to the browser. Defaults to `0`. | ||
|
|
||
| * `:iframe_attrs` - attrs to be given to the iframe injected by |
There was a problem hiding this comment.
間違って前回のbranchで戻してしまってたので再度削除
ymtszw
approved these changes
Feb 20, 2023
|
確認完了、こちらのPRはcloseしてsiiibo-appの依存先をv1.4.1-HMRに変更します |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fork & patch of Phoenix.LiveReload v1.4.1 for internal use.
We won't merge this!! Just for review.
1.4.1対応してv1.4.0 をbaseとしたPRになります、手元環境ではこちらでHMR挙動が維持されていることを確認しました