forked from phoenixframework/phoenix_live_reload
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.4.1-HMR for review #5
Closed
Closed
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
207cc31
send updates when liveview files are updated
bemesa21 779eb20
accepts multiple topics-patterns
bemesa21 573a791
add liveviews reload test
bemesa21 78459f8
Merge pull request #131 from phoenixframework/bms_liveview_reload
chrismccord 43b923b
Release 1.4.1
chrismccord 708af20
Merge remote-tracking branch 'upstream/master' into v1.4.1-HMR
KyosukeUryu 0340405
Fix nits
KyosukeUryu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -40,12 +40,13 @@ defmodule Phoenix.LiveReloader do | |
* `:script_attrs` - HACK attrs to be given to the script injected by | ||
live reload. Expects a keyword list of atom keys and string values. | ||
|
||
* `:notify` - a keyword list of topics pointing to a list of patterns. | ||
A mesage of the form `{:phoenix_live_reload, topic, path}` will be | ||
broadcast on the topic whenever file in the list of patterns changes. | ||
|
||
* `:debounce` - an integer in milliseconds to wait before sending | ||
live reload events to the browser. Defaults to `0`. | ||
|
||
* `:iframe_attrs` - attrs to be given to the iframe injected by | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 間違って前回のbranchで戻してしまってたので再度削除 |
||
live reload. Expects a keyword list of atom keys and string values. | ||
|
||
* `:target_window` - the window that will be reloaded, as an atom. | ||
Valid values are `:top` and `:parent`. An invalid value will | ||
default to `:top`. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
defmodule PhoenixLiveReload.Mixfile do | ||
use Mix.Project | ||
|
||
@version "1.4.0" | ||
@version "1.4.1" | ||
|
||
def project do | ||
[ | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
基本的には:notifyオプションの追加で
notify_patterns
からPubSubで他のappにも通知できるようになったのが主な修正のようでした。PR見た感じ
:phoenix_live_view
で利用できるように拡張したらしいphoenixframework#131
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:naruhodo: