Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in _grid.scss with Jekyll #4

Closed
cheshire137 opened this issue Apr 9, 2016 · 5 comments
Closed

Error in _grid.scss with Jekyll #4

cheshire137 opened this issue Apr 9, 2016 · 5 comments
Assignees
Labels
Bug

Comments

@cheshire137
Copy link

@cheshire137 cheshire137 commented Apr 9, 2016

I'm trying to use Siimple's SCSS files in my Jekyll site. I'm importing siimple.scss but I get the following error when I try to run Jekyll:

  Conversion error: Jekyll::Converters::Scss encountered an error while converting '/css/style.scss':
                    Invalid CSS after " width: #{$w}%": expected expression (e.g. 1px, bold), was "; display: inli..." on line 41
jekyll 3.1.2 | Error:  Invalid CSS after "    width: #{$w}%": expected expression (e.g. 1px, bold), was "; display: inli..." on line 41

It seems to be having a problem with line 41 of _grid.scss:

    width: #{$w}%; display: inline-block; vertical-align: top; float: left; padding: 1%;
@jmjuanes jmjuanes added the Bug label Apr 9, 2016
@jmjuanes jmjuanes self-assigned this Apr 9, 2016
@jmjuanes
Copy link
Member

@jmjuanes jmjuanes commented Apr 9, 2016

Hi @cheshire137.

Thanks for your issue. I think that the problem is with #{$w}%. I have updated the _grid.scss file. Can you try it and check if now works? Thanks!

@cheshire137
Copy link
Author

@cheshire137 cheshire137 commented Apr 9, 2016

That works, thank you!

@jmjuanes
Copy link
Member

@jmjuanes jmjuanes commented Apr 9, 2016

Sorry, I have found a bug in the correction. I have fixed it, so please use the latest version that I have published (v1.3.3).

Check if now works correctly and sorry for the inconvenience.

@cheshire137
Copy link
Author

@cheshire137 cheshire137 commented Apr 9, 2016

Ah, I bet that bug you found was the one I was just going to mention: you end up with width: "72.99%" instead of width: 72.99%. :) Using the latest now, seems good so far!

@jmjuanes
Copy link
Member

@jmjuanes jmjuanes commented Apr 9, 2016

Excellent! Thank you very much for using Siimple 😄

@jmjuanes jmjuanes closed this Apr 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.