Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add German localisation #9

Merged
merged 2 commits into from
May 29, 2020
Merged

Add German localisation #9

merged 2 commits into from
May 29, 2020

Conversation

gitlocalize-app[bot]
Copy link
Contributor

@siku2
Copy link
Owner

siku2 commented May 29, 2020

@NettoHikari I have no idea if GitLocalize sent you a notification (it didn't send me one) so I'm just pinging you here again to make sure.
Thank you very much for taking the time to translate the strings! ❤️

I made some minor adjustments:

  • Changed "Überspringen rückgängig machen" to "Zurück" because this string needs to be short. It might not be perfectly accurate but I feel it gets the point across.
  • Changed "Mit Kommata unterteilte [...]" to "Komma getrennte [...]". Quite honestly I only did this because I thought "Kommata" was a typo 😓. Turns out it's not so I look rather dumb right now but I feel like my version doesn't read any worse.

If you have a problem with my changes don't hesitate to let me know, I trust you to make the right call.

@siku2 siku2 merged commit 3df9a47 into master May 29, 2020
@siku2 siku2 deleted the gitlocalize-11947 branch May 29, 2020 00:39
@NettoHikari
Copy link
Contributor

Hey!

You're welcome. At first, I was out and about to create an issue on GitHub, because the addon didn't work for me at first. After I enabled debug logs, it suddenly started working, so I decided to take a couple minutes and translate the strings real quick.

Regarding your questions:

  • "Zurück" should be fine
  • "Durch Kommata getrennte [...]" should be better. Just "Komma getrennte [...]" is not correct, unfortunately.

Thank you very much for developing this add-on. I could also do a Japanese translation as well.

Greetings from Germany

@siku2
Copy link
Owner

siku2 commented May 29, 2020

@NettoHikari Thanks for the correction, I adjusted it in a1ac5eb.

If you have the time, could you take a look at the addon.xml file too? It also contains a few strings that need to be localized. GitLocalize sadly doesn't detect them and I haven't found a good way to handle those yet.
Only the summary, description, and disclaimer tags need to be translated.


I could also do a Japanese translation as well.

I would love to see that! I don't know if you can add it as a language on GitLocalize yourself - please give it a shot because I would really like to know. Otherwise just tell me and I'll add it for you.

@NettoHikari
Copy link
Contributor

Sorry, I actually didn't notice you answered. :) I can check that later!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants