-
-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove obsolete/broken native markdown class #1610
Remove obsolete/broken native markdown class #1610
Conversation
By the way, unless I am mistaken, it seems SILE's dependency on cosmo is no longer required if the "vendored" Lunamark library is removed. I have not addressed that here -- But if we want to do it too, please ping me and discuss before, if possible. |
Thanks for the heads up, and will do. I'd also seriously consider getting markdown.sile promoted to this ORG or even back in core in conjunction with dropping this module, but haven't been able to investigate that yet. |
e9f4eba
to
718d97d
Compare
Merely rebased / forced push to also remove the |
718d97d
to
5f46283
Compare
@Omikhleia I think you are right about cosmo being no longer needed here. I'll drop it, but I don't understand your issue with LPEG. Maybe a dedicated issue for that if it is something I might be able to help look into? |
Targeting |
This PR is a clean-up proposal:
Rationale:
By the way, as a consequence, some old issues are no longer applying:
Of course, behind that quite-needed "good bye, legacy markdown class!" proposal, they are due credits that shouldn't be ignored. So thanks @simoncozens, @alerque and others that had the idea of using Lunamark, making that early attempt and foster the idea.